Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[svelte-kit-scss] Fix: exclude spec and test files #1199

Merged
merged 2 commits into from
Dec 15, 2023
Merged

[svelte-kit-scss] Fix: exclude spec and test files #1199

merged 2 commits into from
Dec 15, 2023

Conversation

iansamz
Copy link
Contributor

@iansamz iansamz commented Mar 21, 2023

Type of change

  • Documentation change
  • Bug fix

Summary of change

Checklist

  • These changes follow the contributing guidelines
  • This starter kit has been approved by the maintainers
  • Changes for this new starter kit are being pushed to an integration branch instead of main
  • All dependencies are version locked
  • This fix resolves #
  • I have verified the fix works and introduces no further errors

@iansamz iansamz requested a review from mbicknese March 21, 2023 16:56
@iansamz iansamz self-assigned this Mar 21, 2023
@netlify
Copy link

netlify bot commented Mar 21, 2023 •
edited
Loading

✅ Deploy Preview for starter-dev canceled.

Name Link
🔨 Latest commit 9d0194e
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/6419e7483e878300070f63fb

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dustinsgoodman dustinsgoodman merged commit 24d0f73 into main Dec 15, 2023
@dustinsgoodman dustinsgoodman deleted the fix/exclude-test-files-coverage branch December 15, 2023 19:42
@thisdot-bot
Copy link

Hi @iansamz. 👋

Congrats on your first PR being approved and merged! 🎉

Thank you for taking the time to contribute to starter.dev. ❤️

We look forward to your next contribution. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyktoremario vyktoremario vyktoremario approved these changes

@ihardz ihardz ihardz approved these changes

@mbicknese mbicknese mbicknese approved these changes

Assignees

@iansamz iansamz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iansamz @thisdot-bot @mbicknese @ihardz @vyktoremario @dustinsgoodman