A whole bunch of fixes #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently you can change the data and it will change the projected admissions plot before running the model again
this avoids the issue of the predictions plot being rebuilt from a change in the data but no results
giving up on aligning axes at this point
samclifford
requested review from
erees,
esnightingale,
pearsonca and
thibautjombart
just need to fix what happens when the quantiles are the same
|
This also addresses #81 and will probably close #78 seeing as @thibautjombart was the one who had reservations about the colour scheme. |
thibautjombart
approved these changes
May 14, 2020
There was a problem hiding this comment.
Looks great to me. Added a small change to the text for displaying the table, to state this is bed occupancy. I don't think we need to add an option for a table of admissions (or maybe on the todo list for later), mostly in the interest of a timely release / submission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just put together the additional text for the app (please review), branching process, halving time, and put some new defaults in based on other work. Most of this has been in
origin/incidence_plotfor a while.Have also just fixed some issues where no cases led to an error rather than to a zero.
This addresses and probably closes #43 #49 #56 #58 #71 #73 #74 #75 #76