Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome text partially under menu bar #58

Open
samclifford opened this issue Apr 8, 2020 · 10 comments
Open

Welcome text partially under menu bar #58

samclifford opened this issue Apr 8, 2020 · 10 comments
Labels

Comments

@samclifford
Copy link
Collaborator

When launched on my Mac, the text box is obscured by the menu bar because the menu bar doesn't have enough horizontal space and so ends up on two lines. It's the weird position being too narrow for one line but too wide for mobile layout.

@thibautjombart
Copy link
Owner

Thanks for checking. Could you share a screenshot to get a better idea of the issue?

@samclifford
Copy link
Collaborator Author

Screen Shot 2020-04-08 at 11 58 18 am

Screen Shot 2020-04-08 at 11 58 26 am

Screen Shot 2020-04-08 at 11 58 31 am

This might be solveable by moving the title of the app to be outside the menu bar and removing the CMMID logo (other apps are made available via the cmmid.github.io page and are wrapped inside that site's layout style).

@thibautjombart
Copy link
Owner

Just to check: can you try seeing this on firefox or chrome? The native browser in RStudio is terrible, it might just work on chrome?

@thibautjombart
Copy link
Owner

thibautjombart commented Apr 8, 2020

On a separate point: indeed the logo may not be that useful. It looks good when the app is run on its own, but not on the CMMID website (shot of the old version):
image

@samclifford
Copy link
Collaborator Author

I get the same behaviour on Chrome and Safari.

@samclifford
Copy link
Collaborator Author

To be clear, this is resolved by resizing the window.

@thibautjombart
Copy link
Owner

Okay I can reproduce the issue. It seems it might be a css issue? It was also present in the previous version:
image

@samclifford
Copy link
Collaborator Author

Stripping out the CMMID logo would solve this. In any case, it's redundant when displayed in the CMMID.github.io page.

@thibautjombart
Copy link
Owner

thibautjombart commented Apr 27, 2020 via email

@samclifford
Copy link
Collaborator Author

This is fixed... somewhere. At least before b0e2b1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants