Looser check #15
Open
Looser check #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etwork is not yet ready
…ult is 'glusterfs'.
Signed-off-by: Christophe Vanlancker <[email protected]>
…ouble entries in fstab Signed-off-by: Christophe Vanlancker <[email protected]>
IMHO, previous 'unless' statement was ineffective to prevent successive attempts of volume startup leading to multiple log entries.
- Do not probe local host - Fix the checking of the Started condition of the volume.
we use the params pattern here, while at the same time making service_name overwritable as parameter. n.b.: we could/should do this for all other parameters.
again we expose the client package name through as class parameter, determining the value through glusterfs::params.
this way we can match against the fqdn as well as the hostname
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a fix on top of #10