Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplment >= competitor limit check #673

Merged
merged 9 commits into from
Oct 29, 2024

Conversation

dunkOnIT
Copy link
Collaborator

@dunkOnIT dunkOnIT commented Sep 4, 2024

Previous version of this PR was reverted, as it triggered an error in live environments where Redis only returns strings

@FinnIckler
Copy link
Member

render json: { count: Registration.accepted_competitors_count(competition_id).to_i }

Here I just use .to_i not sure what is better

@FinnIckler
Copy link
Member

Anyway how you implement it, you should remove the to_i from my line

@FinnIckler
Copy link
Member

@dunkOnIT please fix the conflicts and remove the to_i where Registration.accepted_competitors_count(competition_id) is called elsewhere

@FinnIckler FinnIckler merged commit 2233ae0 into thewca:main Oct 29, 2024
1 check passed
@dunkOnIT dunkOnIT deleted the fix/competitor-limit-check branch October 29, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants