Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Table in WCA Payment Authorization Policy #427

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

Nanush7
Copy link
Member

@Nanush7 Nanush7 commented Sep 20, 2024

Fixes: table not rendering + some columns go off the page.

@Nanush7 Nanush7 self-assigned this Sep 20, 2024
@Nanush7
Copy link
Member Author

Nanush7 commented Sep 20, 2024

The table now renders, but there is a different problem now:
Captura de pantalla 2024-09-20 a la(s) 11 30 23

@EdHollingdale
Copy link
Contributor

What if in the table we change "Championships" to "Champ." and "Equipment" to "Equip."?

@Nanush7
Copy link
Member Author

Nanush7 commented Sep 20, 2024

Breaking words:
Captura de pantalla 2024-09-20 a la(s) 11 56 54

I'll now try scaling the whole table

@Nanush7
Copy link
Member Author

Nanush7 commented Sep 20, 2024

Fixed!

Captura de pantalla 2024-09-20 a la(s) 13 18 31

@Nanush7 Nanush7 marked this pull request as ready for review September 20, 2024 16:21
@Nanush7 Nanush7 requested review from a team as code owners September 20, 2024 16:21
Copy link
Member

@dmint789 dmint789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@nsilvestri nsilvestri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by the Board as non-content changes.

@EdHollingdale
Copy link
Contributor

@thewca/software-team are you able to review this and merge?

@nsilvestri
Copy link
Contributor

Hi Ed, I don't believe WST approval is required here. You are good to merge.

@Nanush7
Copy link
Member Author

Nanush7 commented Sep 30, 2024

We (at least WQAC members) do need WST approval to merge. Github won't let us otherwise.

@nsilvestri nsilvestri merged commit 1e0207e into thewca:master Sep 30, 2024
1 check failed
@nsilvestri
Copy link
Contributor

Ope, that's an issue with CODEOWNERS. I'll see if I can get that resolved.

@Nanush7 Nanush7 deleted the fix-wpap-table branch September 30, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants