-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use filepath.Join when combining filesystem components #611
Use filepath.Join when combining filesystem components #611
Conversation
Signed-off-by: Fredrik Skogman <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #611 +/- ##
==========================================
- Coverage 70.54% 70.51% -0.04%
==========================================
Files 10 10
Lines 2122 2123 +1
==========================================
Hits 1497 1497
- Misses 504 505 +1
Partials 121 121 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Fredrik Skogman <[email protected]>
Signed-off-by: Fredrik Skogman <[email protected]>
Signed-off-by: Fredrik Skogman <[email protected]>
tuf client cli test also works on Windows now and some other, only the multi-repo test that is failing now 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM FWIW
I would recommend merging this, then I'll look at the multi repo test in a new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Partly fixes #605
The
example-root-signing
test should now work on Windows.