Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipc4: copier: unused code cleanup #9701

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

serhiy-katsyuba-intel
Copy link
Contributor

  • ipc4: ipcgtw: code cleanup
    The use of intermediate endpoint buffer was removed from gateways some time ago. However, the IPC gateway code still contained logic that unnecessarily creates such endpoint buffer. That code has now been removed.

  • ipc4: copier: remove unused endpoint_buffer[]
    The use of endpoint buffers in gateways was removed some time ago. endpoint_buffer[] is a leftover from an earlier refactoring, is not used, and can be removed.

  • ipc4: copier: remove unused endpoint[]
    The endpoint[] array is never initialized and is not really used.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @ranj063 pls review

Copy link
Collaborator

@ranj063 ranj063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except for a minor nit

src/audio/copier/copier_ipcgtw.c Show resolved Hide resolved
The use of intermediate endpoint buffer was removed from gateways
some time ago. However, the IPC gateway code still contained logic
that unnecessarily creates such endpoint buffer. That code has now
been removed.

Signed-off-by: Serhiy Katsyuba <[email protected]>
The use of endpoint buffers in gateways was removed some time ago.
endpoint_buffer[] is a leftover from an earlier refactoring, is not used,
and can be removed.

Signed-off-by: Serhiy Katsyuba <[email protected]>
The endpoint[] array is never initialized and is not really used.

Signed-off-by: Serhiy Katsyuba <[email protected]>
@kv2019i
Copy link
Collaborator

kv2019i commented Dec 3, 2024

sof-docs fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3A%22Known+PR+Failures%22+

@kv2019i kv2019i merged commit fef7091 into thesofproject:main Dec 3, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants