Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Test: Audio: Fix IIR and FIR tests handling in process_test.m #9685

Merged

Conversation

singalsu
Copy link
Collaborator

The component names are slightly different in IPC4 test topologies for sof-testbench4, so the script is updated to handle both names like eq-iir and eqiir. This avoids reporting failure in gain and frequency response mask tests.

The help text and default are also updated for default sof-testbench4.

@singalsu singalsu marked this pull request as ready for review November 27, 2024 13:01
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu do we also need to spell this out in a comment or readme.md somewhere that ipc3/4 use different names for certain components ?

The component names are slightly different in IPC4 test
topologies for sof-testbench4, so the script is updated to handle
both names like eq-iir and eqiir. This avoids reporting failure in
gain and frequency response mask tests.

The help text and default are also updated for default
sof-testbench4.

Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch converts the README to Markdown .md format and
updates the descriptions for key scripts for audio tests.

Signed-off-by: Seppo Ingalsuo <[email protected]>
@singalsu singalsu force-pushed the process_test_fix_iireq_iireq_test branch from 7d862c0 to d5eb301 Compare November 29, 2024 13:26
@singalsu
Copy link
Collaborator Author

@singalsu do we also need to spell this out in a comment or readme.md somewhere that ipc3/4 use different names for certain components ?

There's now update to README.md with this information.

@kv2019i
Copy link
Collaborator

kv2019i commented Dec 3, 2024

SOFCI TEST

@kv2019i
Copy link
Collaborator

kv2019i commented Dec 3, 2024

sof-docs fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3A%22Known+PR+Failures%22+

@kv2019i kv2019i merged commit d85c696 into thesofproject:main Dec 3, 2024
43 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants