Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology2: add sof-ptl-rt722-96k support #9679

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

bardliao
Copy link
Collaborator

Add 96KHz support on jack and deep buffer PCMs on the sof-ptl-rt722.tplg.

Deep buffer should use the same rate as the original device.

Signed-off-by: Bard Liao <[email protected]>
Set 96KHz rate in jack and deef buffer PCMs.

Signed-off-by: Bard Liao <[email protected]>
@bardliao bardliao requested review from ranj063 and kv2019i November 25, 2024 12:04
@bardliao bardliao requested a review from jsarha as a code owner November 25, 2024 12:04
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only one question whether the 96 tplg file should be production or development.

SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\
SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,\
JACK_RATE=96000,DEEP_BUF_JACK_RATE=96000"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is production folder correct place for this? I don't think we have any kernel configuration that would use this out-of-the-box...?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes production is the right place.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is production folder correct place for this? I don't think we have any kernel configuration that would use this out-of-the-box...?

Currently, there is no product uses the tplg by default. However, it can be used with options snd-sof-pci tplg_filename=sof-ptl-rt722-96k.tplg

@kv2019i kv2019i merged commit 5249d28 into thesofproject:main Nov 27, 2024
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants