-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: intel: remove remaining references to MN driver #9671
Conversation
Found in review of #9667 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to merge when ready.
Unfortunately we have a problem on TGL with IPC4, the test with SSP does not pass. The question is what do we do about it or should we throw away this test? I would like it to be agreed with the developers Issue: |
@wszypelt pls disable this test. I would not fully delete though, just disable. |
@lgirdwood @wszypelt This is an expected result that some SSP tests will fail on cAVS2.5. This PR removes the SOF side CONFIG option, but we are still using old Zephyr here. so the SSP driver code for SSP2.5 clocks will be then partially disabled. I expect the tests to pass when Zephyr part is merged and can test together with this PR (and thus the DNM for this). |
cb77aa2
to
a172410
Compare
New version pushed:
|
DSP crashes on ace30, probably caused by latest Zephyr main:
|
Fix is identified for Zephyr upstream regression, but I'll mark this PR with DNM until the Zephyr part is merged and we can try again. |
I'll rebase this once #9712 is merged. |
The Zephyr SSP driver has had a dependency to CONFIG_INTEL_NM defined in SOF, so this has not been removed before. This is now cleaned up on Zephyr side, so we can proceed to remove the remaining bits of the Intel MN driver on SOF side. Signed-off-by: Kai Vehmanen <[email protected]>
a172410
to
3b0271f
Compare
New version uploaded:
|
@lgirdwood Ack, I think the LNL fails are unrelated. I think the BIOS update broke this DUT and it's loading the wrong config:
|
@kv2019i @lgirdwood Internal Intel CI System, all green |
The Zephyr SSP driver has had dependency to CONFIG_INTEL_NM defined in SOF, so this has not been removed before. This is now cleaned up on Zephyr side, so we can proceed to remove the remaining bits of the Intel MN driver on SOF side.