Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology2: Add support for cs42l43 SKU with four host DMICs #9666

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

simontrimmer
Copy link
Contributor

@simontrimmer simontrimmer commented Nov 19, 2024

Add support for another Lenovo SKU that uses cs42l43 and four host side DMICs rather than the CODECs DMICs.

@lgirdwood
Copy link
Member

@bardliao pls review.

@bardliao
Copy link
Collaborator

The main question is that is the SoundWire DMIC used or not. If not, we need to add a quirk in the machine driver. Like Remove CODEC DMIC for specific SKUs by charleskeepax · Pull Request #5186 · thesofproject/linux And, 'SDW_DMIC_STREAM=Capture-SmartMic' is not needed in that case.
If the SoundWire DMIC and the host DMIC coexist, we need to add SDW_DMIC=1

@simontrimmer simontrimmer force-pushed the sof-lnl-cs42l43-l0-4ch branch from dc937fb to 41e90a0 Compare November 19, 2024 16:16
@simontrimmer
Copy link
Contributor Author

@charleskeepax - I've been having some fun with this today, I'll bother you about it more tomorrow

@simontrimmer
Copy link
Contributor Author

Hey @bardliao

The main question is that is the SoundWire DMIC used or not. If not, we need to add a quirk in the machine driver. Like Remove CODEC DMIC for specific SKUs by charleskeepax · Pull Request #5186 · thesofproject/linux And, 'SDW_DMIC_STREAM=Capture-SmartMic' is not needed in that case. If the SoundWire DMIC and the host DMIC coexist, we need to add SDW_DMIC=1

I'm pretty certain that we don't have the SoundWire DMIC so will be adding the SOC_SDW_CODEC_MIC quirk when updating the sof_sdw_quirk_table

Add support for another Lenovo SKU that uses cs42l43 and four host side
DMICs rather than the CODECs DMICs.

Signed-off-by: Simon Trimmer <[email protected]>
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bardliao pl review.

@lgirdwood lgirdwood merged commit ef51d72 into thesofproject:main Nov 21, 2024
43 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants