Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: board: Add define CONFIG_COUNTER #9636

Merged
merged 1 commit into from
Nov 15, 2024
Merged

app: board: Add define CONFIG_COUNTER #9636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/boards/intel_adsp_ace30_ptl.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ CONFIG_SOF_LOG_LEVEL_INF=y
CONFIG_ZEPHYR_LOG=y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use: "app: intel_adsp_ace30_ptl.conf: enable CONFIG_COUNTER" prefix.

Also in commit, I think it's also to mention the test case (even if it's not a public test), but I'd also add a brief sentence CONFIG_COUNTER is required for implementation of basefw_get_ext_system_time(). This makes it easily to look up which piece of code this affects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment, I have corrected the commit title and commit message, regarding the test it has no test cases. It is simply such a test and does not take parameters


# Zephyr / OS features
CONFIG_COUNTER=y
CONFIG_HEAP_MEM_POOL_SIZE=8192
CONFIG_L3_HEAP=y

Expand Down
Loading