Audio: DRC: Use audio_stream_copy() with pass-through configuration #9626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
force-pushed
the
drc_passthrough_mode
branch
from
57cdc86 to
bbda6e8
Compare
|
Note: When a blob has the params.enable set, then the user space switch control as before controls the processing on/off while preserving the internal lookup delay so this change doesn't cause glitches when normally controlling processing. |
lgirdwood
reviewed
Oct 30, 2024
src/audio/drc/drc.c
Outdated
Comment on lines
281
to
292
|
|
||
| if (cd->drc_func == drc_default_pass && cd->config->params.enabled) | ||
| cd->drc_func = drc_find_proc_func(cd->source_format); | ||
|
|
||
| if (!cd->config->params.enabled) | ||
| cd->drc_func = drc_default_pass; |
There was a problem hiding this comment.
Can we spell out the configuration flow and selection in an inline comment too.
There was a problem hiding this comment.
Yep, it's useful to document.
The configuration blob is checked in drc_prepare(). If the blob does not have params.enable set, then it is safe to switch to a more efficient buffer copy function that bypasses the internal DRC lookup delay with channels de-interleave and interleave operations. The enable in the blob is a master switch for DRC. With such configuration in the blob the switch control from user space can't switch the processing on. Therefore it is safe to change the processing function. This change minimizes the MCPS overhead of unused DRC and reduces audio latency. If a new blob is received during streaming, the params.enable is checked again and the processing function is set again if the pass-through copy mode was in use. If the new blob has enable false, then the processing is changed to pass-through mode. The pass-through blob configuration is useful when the same pipeline is used for both headphone and speaker, where DRC is usually disabled for headphone mode. This change saves in hda-generic topologies with the default blob about 1.2 MCPS in TGL platform. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
drc_passthrough_mode
branch
from
bbda6e8 to
c5ef0e3
Compare
lgirdwood
approved these changes
Oct 31, 2024
kv2019i
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration blob is checked in drc_prepare(). If the blob does not have params.enable set, then it is safe to switch to a more efficient buffer copy function that bypasses the internal DRC lookup delay with channels de-interleave and interleave operations. The enable in the blob is a master switch for DRC. With such configuration in the blob the switch control from user space can't switch the processing on. Therefore it is safe to change the processing function. This change minimizes the MCPS overhead of unused DRC and reduces audio latency.
If a new blob is received during streaming, the params.enable is checked again and the processing function is set again if the pass-through copy mode was in use.
A pass-through blob can be applied e.g. when the same pipeline is used for both headphone and speaker, where DRC is usually disabled for headphone mode.
This change saves in hda-generic topologies with the default blob about 1.2 MCPS in TGL platform.