audio: module: Fix passthrough module #9622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After commit 5f6f22d ("audio: module_adapter: Prepare to convert copier to use module interface") period_bytes are no longer computed in module generic prepare. This break the passthrough module as it was using period_bytes computed by upper layers. Fix this by computing period_bytes inside passthrough module prepare function. Fixes: 5f6f22d ("audio: module_adapter: Prepare to convert copier to use module interface") Signed-off-by: Daniel Baluta <[email protected]>
dbaluta
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
kv2019i
as code owners
iuliana-prodan
approved these changes
Oct 29, 2024
LaurentiuM1234
approved these changes
Oct 29, 2024
lgirdwood
approved these changes
Oct 29, 2024
|
@ranj063 good for you ? |
kv2019i
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After commit 5f6f22d ("audio: module_adapter: Prepare to convert copier to use module interface") period_bytes are no longer computed in module generic prepare.
This break the passthrough module as it was using period_bytes computed by upper layers.
Fix this by computing period_bytes inside passthrough module prepare function.
Fixes: 5f6f22d ("audio: module_adapter: Prepare to convert copier to use module interface")