Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio: remove unnecessary inclusion of lib/memory.h #9555

Merged

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Oct 8, 2024

Remove unnecessary incluce statements for lib/memory.h in large number of files in audio. Some are pure bad copy and paste, while in some cases the module has in the past used SHARED_DATA macro, but this has been since been removed. The SHARED_DATA use might be removed later, so add a comment to files where lib/memory.h is only included for this one macro.

Remove unnecessary incluce statements for lib/memory.h in large number
of files in audio. Some are pure bad copy and paste, while in some
cases the module has in the past used SHARED_DATA macro, but this has
been since been removed. The SHARED_DATA use might be removed later,
so add a comment to files where lib/memory.h is only included for
this one macro.

Signed-off-by: Kai Vehmanen <[email protected]>
@kv2019i kv2019i merged commit ec8cf20 into thesofproject:main Oct 9, 2024
42 of 47 checks passed
@kv2019i
Copy link
Collaborator Author

kv2019i commented Oct 10, 2024

Hmm, @thesofproject/maintainers , starting with this PR, the sof-docs job started failing:
""" WARNING: Calling get_html_theme_path is deprecated. If you are calling it to define html_theme_path, you are safe to remove that code."""

Cannot immediately see the connection, but will follow-up with a fix or a bug if this takes longer. FYI, this will show as failure now in all PRs.

UPDATE: it's not caused by this PR -> #9566 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants