Arch: host: Cleanup mixer vs. mixin/mixout component build #9544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build of mixin/mixout didn't work for static library IPC4 testbench build because Kconfig for mixer has "depends on IPC_MAJOR_3". Therefore the if(CONFIG_COMP_MIXER) with IPC version dependent sources was never true. It's replaced with normal component build handling for CONFIG_COMP_MIXER and CONFIG_COMP_MIXIN_MIXOUT. The confusing looking "set(mixer_src ..." from begin of CMakeLists.txt is moved to end where shared libraries of audio modules are built. The default configuration of SOF plugin is changed to CONFIG_COMP_MIXIN_MIXOUT=y to make sure the correct mixer is built for it. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
kv2019i
approved these changes
Oct 7, 2024
ranj063
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build of mixin/mixout didn't work for static library IPC4 testbench build because Kconfig for mixer has
"depends on IPC_MAJOR_3". Therefore the if(CONFIG_COMP_MIXER) with IPC version dependent sources was never true. It's replaced with normal component build handling for CONFIG_COMP_MIXER and CONFIG_COMP_MIXIN_MIXOUT.
The confusing looking "set(mixer_src ..." from begin of CMakeLists.txt is moved to end where shared libraries of audio modules are built.
The default configuration of SOF plugin is changed to CONFIG_COMP_MIXIN_MIXOUT=y to make sure the correct mixer is built for it.