copier: Add bind function to configure source/sink buffers params #9276
Conversation
softwarecki
requested review from
lgirdwood,
tobonex,
kv2019i,
marc-hb,
marcinszkudlinski,
jxstelter,
tmleman,
serhiy-katsyuba-intel and
gbernatxintel
softwarecki
requested review from
RanderWang,
abonislawski and
pblaszko
as code owners
There was a problem hiding this comment.
Driver sends SET_SINK_FORMAT IPC to configure copier module sink processing parameters before bind when there is no processing buffer between connected components. Please also remove sink buffer's update from copier_set_sink_fmt().
It would be nice to simplify copier bind operation, please find my suggestions below
A data producing component is responsible for setting a sink buffer parameters. It is not necessary for the copier to override source buffer parameters. Remove the code responsible for it. Signed-off-by: Adrian Warecki <[email protected]>
Sink format can only be set when the sink buffer is not binded. Sink buffer parameters will be set on binding. Remove redundant code. Signed-off-by: Adrian Warecki <[email protected]>
|
@softwarecki can you confirm if internal CI is good to merge ? Seeing some red on Jenkins, lets rerun to be sure. |
|
SOFCI TEST |
Setting the sink buffers parameters in the copier_update_params function is not sufficient. If a sink buffer is attached during copier operation, the module will not set buffers parameters. Add bind function to configure sink buffers parameters. There is no need to configure sink buffers parameters on each copy. We are assured that they were configured at the time of bind. Remove ipc4_update_buffer_format from the copier_module_copy function. Fixes: thesofproject#9123 Signed-off-by: Adrian Warecki <[email protected]>
|
I restored the code that sets the sink parameters in the I look forward to the new CI results... |
All look good except for LNL SDW, can you check ? I would expect copier changes to fail on all test (not just SDW), we can rerun again if you think its DUT or testing infra related. |
|
@lgirdwood wrote:
The LNL SDW is caused by this: thesofproject/linux#5098 |
|
SOFCI TEST |
|
The pause/resume failure in https://sof-ci.01.org/sofpr/PR9276/build6454/devicetest/index.html?model=LNLM_RVP_HDA&testcase=check-pause-resume-capture-100 is addressed by thesofproject/sof-test#1218, please review. |
|
SOFCI TEST |
|
@lgirdwood Can we proceed with merge? |
Setting the source/sink buffers parameters in the copier_update_params function is not sufficient. If a sink buffer is attached during copier operation, the module will not set buffers parameters. Move the buffer parameter configurations to the new copier_bind bind function. Delete the sink buffers configurations from the copier_module_copy function. There is no need to configure sink buffers parameters on each copy. We are assured that they were configured at the time of bind.
Fixes: #9123