Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several minor miscellaneous patches #8880

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Several minor miscellaneous patches #8880

merged 4 commits into from
Feb 26, 2024

Conversation

lyakh
Copy link
Collaborator

@lyakh lyakh commented Feb 26, 2024

No description provided.

lyakh added 4 commits February 26, 2024 10:42
@lyakh
ace: don't re-define CONFIG_LOG*
00b6799 
CONFIG_LOG and CONFIG_LOG_MODE_DEFERRED are already defined in the
common prj.conf, no need to re-define them additionally in
architecture-specific configurations.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
@lyakh
ipc: (cosmetic) use an existing variable
d3cf9aa 
Use a local variable instead of calling ipc_get() again in
ipc_send_queued_msg().

Signed-off-by: Guennadi Liakhovetski <[email protected]>
@lyakh
ipc4: don't keep stale pointers, avoid double freeing
daa3969 
When freeing memory it's also good to clear the pointer to avoid
use-after-free or double-free bugs.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
@lyakh
multicore: add a timeout when enabling secondary cores
0aaa722 
Replace a potentially infinite loop with one, using a retry counter
to avoid lock ups.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
marcinszkudlinski
marcinszkudlinski approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@marcinszkudlinski marcinszkudlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
consider removing cpu_enable_secondary_core from code, is never used

@lyakh
Copy link
Collaborator Author

lyakh commented Feb 26, 2024

LGTM consider removing cpu_enable_secondary_core from code, is never used

@marcinszkudlinski indeed it isn't. Does it mean, that the CONFIG_ZEPHYR_NATIVE_DRIVERS=n case for multicore Zephyr is broken?

@lgirdwood
Copy link
Member

LGTM consider removing cpu_enable_secondary_core from code, is never used

@marcinszkudlinski indeed it isn't. Does it mean, that the CONFIG_ZEPHYR_NATIVE_DRIVERS=n case for multicore Zephyr is broken?

No, it's not broken, it just means the RTOS feature has completed transition from SOF to Zephyr RTOS. We can now remove in a followup PR.

@lgirdwood lgirdwood merged commit 49abf3f into thesofproject:main Feb 26, 2024
40 of 44 checks passed
@lyakh lyakh deleted the 240226-misc branch February 26, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmleman tmleman tmleman approved these changes

@marcinszkudlinski marcinszkudlinski marcinszkudlinski approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@bardliao bardliao Awaiting requested review from bardliao bardliao is a code owner

@pblaszko pblaszko Awaiting requested review from pblaszko pblaszko is a code owner

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@kv2019i kv2019i Awaiting requested review from kv2019i kv2019i is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lyakh @lgirdwood @marcinszkudlinski @tmleman