Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: perf_overlay: disable CONFIG_ADSP_IDLE_CLOCK_GATING #8870

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

abonislawski
Copy link
Member

Perf build uses xtensa timer

Perf build uses xtensa timer

Signed-off-by: Adrian Bonislawski <[email protected]>
CONFIG_TIMING_FUNCTIONS=y
CONFIG_ADSP_IDLE_CLOCK_GATING=n
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abonislawski I think a comment here would not hurt to explain use of xtensa timer and clock gating are not compatible. Even better would be to have this at Kconfig level but a comment here goes a long way.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we should make sure Kconfig forbids perf with clock gating on Intel devices, but can be an incremental fix.

@lgirdwood
Copy link
Member

@abonislawski some CI tests have reported failures.

@wszypelt
Copy link

wszypelt commented Feb 23, 2024

@abonislawski @lgirdwood all green now in Internal Intel CI Tests

@kv2019i kv2019i merged commit dc80db7 into thesofproject:main Mar 4, 2024
40 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants