topology2: add support for imx8mp #8860
Conversation
iuliana-prodan
requested review from
marc-hb,
ranj063 and
jsarha
as code owners
|
@ranj063 @RanderWang can you, please, review this PR. I also have some questions around the files, if you can answer, I really appreciate it. |
iuliana-prodan
changed the title
Move common_definitions.conf to common folder since this will be used by other companies to define their topologies. Signed-off-by: Iuliana Prodan <[email protected]>
Move gain-playback/capture pipelines out of cavs folder since these can used by others. Update cavs topologies to fix compilation by adding include/pipelines as searchdir. Signed-off-by: Iuliana Prodan <[email protected]>
Add SAI DAI class definition, SAI DAI objects can be
instantiated as:
Object.Dai.SAI."N" {
direction "duplex"
dai_name "NoCodec-0"
id 0
Object.hw_config."0" {
mclk_freq 12288000
bclk_freq 3072000
tdm_slot_width 32
}
Object.dai."playback" {
period_source_count 2
period_sink_count 0
}
Object.dai."capture" {
period_source_count 0
period_sink_count 2
}
}
Signed-off-by: Iuliana Prodan <[email protected]>
Add SAI as dai_type for dai-copier component. Signed-off-by: Iuliana Prodan <[email protected]>
Add playback topology for i.MX8MP with wm8960 codec Signed-off-by: Iuliana Prodan <[email protected]>
iuliana-prodan
force-pushed
the
tplg2_imx8mp
branch
from
5cd3890 to
eb4e913
Compare
|
Changes in V2:
@ranj063 @RanderWang @lgirdwood if you consider I can move the first two patches in other PR since these are generic, not related with 8MP topology (but this depends on the first 2). |
There was a problem hiding this comment.
Placing this file here will very likely make it part of official sof-bin releases by default. Just making sure everyone is aware.
| @@ -1,4 +1,4 @@ | |||
| # Commonly used definitions in cavs topologies | |||
| # Commonly used definitions in topologies | |||
There was a problem hiding this comment.
We'll need to figure out how tp move the SSP_BLOB version definitions to some Intel specific file, but rest are indeed generic!
|
|
||
| Define { | ||
| HEADSET_PLAYBACK_PCM_STREAM_NAME "Headset Playback" | ||
| HEADSET_PCM_NAME "Headset" |
|
@ranj063 Good to merge? |
Please do for smaller and faster reviews and (more importantly) more CI https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#defining-smaller-prs |
@marc-hb can we please leave it as is, now. |
|
Our daily tests run for longer and have more coverage. I doubt this would have make a difference in this particular case but you asked, so I just gave you the general guideline :-) |
Thanks @marc-hb. |
Add SAI class for topology2.
Add simple playback topology2 for i.MX8MP.