Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: convert: fix variable type for negative value #8839

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

abonislawski
Copy link
Member

This will fix scan tool reported issue:

time_precision variable can be used as -1

case 'f':
        config.time_precision = atoi(optarg);
   	if (config.time_precision < 0) {

case 'g':
   	config.time_precision = -1;

Fixes commit ff9343a

Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbaluta can you please get ready to test (future versions of) this with the GCC 13 compiler that produced the warning reported in #8778? Intel does not use this on the main branch.

tools/logger/convert.c Outdated Show resolved Hide resolved
time_precision variable can be used as -1

Fixes commit ff9343a ("logger: convert: Fix compile time error with
newer toolchain")

Signed-off-by: Adrian Bonislawski <[email protected]>
@lgirdwood lgirdwood merged commit af80acc into thesofproject:main Feb 13, 2024
38 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants