ipc4: fix a wrong variable #8838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sink_basecfg_ext should actually be src_basecfg_ext in one location in ipc_comp_connect(), fix it and move variable definitions to where they are used to reduce the chance of such a bug in the future. Signed-off-by: Guennadi Liakhovetski <[email protected]>
lyakh
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
marcinszkudlinski
approved these changes
Feb 6, 2024
ranj063
approved these changes
Feb 6, 2024
serhiy-katsyuba-intel
approved these changes
Feb 7, 2024
dnikodem
approved these changes
Feb 7, 2024
lgirdwood
approved these changes
Feb 7, 2024
|
@lyakh can you check CI, think a lot of the reports are unrelated. Thanks EDIT: ignore, its not for main. |
|
@lyakh is this in main ? didn't see any reference to a cherry-pick |
|
@lgirdwood it should not be merged to main. This PR is replacing solution from 007: #8685 |
marcinszkudlinski
merged commit 17a9678
into
thesofproject:mtl-007-drop-stable
19 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sink_basecfg_ext should actually be src_basecfg_ext in one location in ipc_comp_connect(), fix it and move variable definitions to where they are used to reduce the chance of such a bug in the future.