Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google aec sink src dp #8722

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Google aec sink src dp #8722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a16eba
dp: look at all sinks and sources in default "is ready"
marcinszkudlinski Dec 21, 2023
f199670
AEC: convert aec to use sink/src interface
marcinszkudlinski Jan 11, 2024
37c5a26
AEC: Enable Google AEC with Mock compliation
marcinszkudlinski Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/boards/intel_adsp_ace15_mtpm.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,6 @@ CONFIG_DEBUG_COREDUMP_MEMORY_DUMP_MIN=y
CONFIG_PROBE=y
CONFIG_PROBE_DMA_MAX=2
CONFIG_LOG_TIMESTAMP_64BIT=y

CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING=y
CONFIG_COMP_STUBS=y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

From src/audio/Kconfig
"CONFIG_STUBS: This should only be used in testing environments like fuzzers or CI."

Good example of #9386

cc: @cujomalainey

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now being reverted in:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9410 results and discussion seem to show a test seems to depend on this!

35 changes: 24 additions & 11 deletions src/audio/google/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ config COMP_GOOGLE_RTC_AUDIO_PROCESSING
This component takes raw microphones input and playback reference
and outputs an echo-free microphone signal.

config COMP_GOOGLE_RTC_USE_32_BIT_FLOAT_API
depends on COMP_GOOGLE_RTC_AUDIO_PROCESSING
bool "Use 32bit API in Google Audio processing"
default n
help
Selects an API to be used in communication with the Google real-time
communication audio processing: 32bit float or 16bit integer

config COMP_GOOGLE_RTC_AUDIO_PROCESSING_SAMPLE_RATE_HZ
depends on COMP_GOOGLE_RTC_AUDIO_PROCESSING
int "Sample rate for Google Real Time Communication Audio processing"
Expand All @@ -32,21 +40,26 @@ config COMP_GOOGLE_RTC_AUDIO_PROCESSING_SAMPLE_RATE_HZ
Sets the sample rate for the memory buffer for the Google real-time
communication audio processing.

config COMP_GOOGLE_RTC_AUDIO_PROCESSING_NUM_CHANNELS
depends on COMP_GOOGLE_RTC_AUDIO_PROCESSING
int "Number of channels to process for Google Real Time Communication Audio processing"
default 1
config COMP_GOOGLE_RTC_AUDIO_PROCESSING_CHANNEL_MAX
marcinszkudlinski marked this conversation as resolved.
Show resolved Hide resolved
int "Max number of AEC channels"
default 2
help
Sets the number of channels to process in the Google real-time
communication audio processing.
Sets the maximum number source/sink processing channels Google Real
Time Communication Audio Processing will use for. This is a
computation and memory budget tunable. Channel counts are
retrieved at runtime, but channels higher than this number
are ignored (on input) or cleared (output).

config COMP_GOOGLE_RTC_AUDIO_PROCESSING_NUM_AEC_REFERENCE_CHANNELS
depends on COMP_GOOGLE_RTC_AUDIO_PROCESSING
int "Number of AEC reference channels for Google Real Time Communication Audio processing"

config COMP_GOOGLE_RTC_AUDIO_REFERENCE_CHANNEL_MAX
int "Max number of AEC reference channels"
default 2
help
Sets the number AEC reference channels in the Google real-time
communication audio processing.
Sets the maximum number source/sink reference channels Google Real
Time Communication Audio Processing will use for. This is a
computation and memory budget tunable. Channel counts are
retrieved at runtime, but channels higher than this number
are ignored

config COMP_GOOGLE_RTC_AUDIO_PROCESSING_MEMORY_BUFFER_SIZE_BYTES
depends on COMP_GOOGLE_RTC_AUDIO_PROCESSING
Expand Down
Loading
Loading