Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xtensa-build-zephyr.py: remove imx8ulp from --all #8493

Merged
merged 1 commit into from
Nov 20, 2023
Merged

xtensa-build-zephyr.py: remove imx8ulp from --all #8493

merged 1 commit into from
Nov 20, 2023

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Nov 17, 2023

As of today's Zephyr commit 92fb8b223825, imx8ulp does not compile.

Do not remove any of its data from xtensa-build-zephyr.py but exclude it from --all

Fixes:

scripts/xtensa-build-zephyr.py --all

-- Board: nxp_adsp_imx8ulp
No board named 'nxp_adsp_imx8ulp' found.

CMake Error at zephyr/cmake/modules/boards.cmake:167 (message):
  Invalid BOARD; see above.
Call Stack (most recent call first):
  cmake/modules/zephyr_default.cmake:129 (include)
  share/zephyr-package/cmake/ZephyrConfig.cmake:66 (include)
  share/zephyr-package/cmake/ZephyrConfig.cmake:92 (include_boilerplate)
  CMakeLists.txt:5 (find_package)

Fixes 61ccb4c ("scripts: zephyr: Add support to build sof for imx8ulp")

@marc-hb
xtensa-build-zephyr.py: remove imx8ulp from --all
e980319 
As of today's Zephyr commit 92fb8b223825, imx8ulp does not compile.

Do not remove any of its data from `xtensa-build-zephyr.py` but exclude
it from --all

Fixes:
```
scripts/xtensa-build-zephyr.py --all

-- Board: nxp_adsp_imx8ulp
No board named 'nxp_adsp_imx8ulp' found.

CMake Error at zephyr/cmake/modules/boards.cmake:167 (message):
  Invalid BOARD; see above.
Call Stack (most recent call first):
  cmake/modules/zephyr_default.cmake:129 (include)
  share/zephyr-package/cmake/ZephyrConfig.cmake:66 (include)
  share/zephyr-package/cmake/ZephyrConfig.cmake:92 (include_boilerplate)
  CMakeLists.txt:5 (find_package)
```

Fixes 61ccb4c ("scripts: zephyr: Add support to build sof for
imx8ulp")

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb marc-hb marked this pull request as ready for review November 17, 2023 23:58
@marc-hb marc-hb mentioned this pull request Nov 18, 2023
Merged
@marc-hb
Copy link
Collaborator Author

marc-hb commented Nov 18, 2023 •
edited
Loading

Interesting (and unrelated) [ 58.637265] <err> ipc: ipc4_module_process_dx: failed to disable core 2 regression in https://sof-ci.01.org/sofpr/PR8493/build14995/devicetest

It reminds me about zephyrproject-rtos/zephyr@a4b9692155a3 ?
("soc: intel_adsp/cavs: add secondary dsp context save support)

cc: @RanderWang , @lyakh , @andyross , @tmleman , @kv2019i

@fredoh9 did you already file an issue for this one?

[   58.636105] <inf> ipc: ipc_cmd: rx	: 0x12010000|0x0
[   58.636370] <inf> dma: dma_put: dma_put(), dma = 0x9e09f160, sref = 0
[   58.636403] <inf> dai_intel_ssp: dai_ssp_pm_runtime_dis_ssp_power: dai_ssp_pm_runtime_dis_ssp_power index 2
[   58.636541] <err> dai_intel_ssp: dai_ssp_poll_for_register_delay: dai_ssp_poll_for_register_delay poll timeout reg 465924 mask 1024 val 1024 us 125
[   58.636556] <wrn> dai_intel_ssp: dai_ssp_pm_runtime_dis_ssp_power: dai_ssp_pm_runtime_dis_ssp_power warning: timeout
[   58.637165] <inf> ipc: ipc_cmd: rx	: 0x47000000|0x0
[   58.637265] <err> ipc: ipc4_module_process_dx: failed to disable core 2
[   58.637275] <err> ipc: ipc_cmd: ipc4: MODULE_MSG failed with err 6
ASSERTION FAIL [k_sched_current_thread_query()->base.sched_locked != 0U] @ /srv/home/jenkins/workspace/sof_generic_build/zephyr/kernel/sched.c:1117
ASSERTION FAIL [z_spin_lock_valid(l)] @ /srv/home/jenkins/workspace/sof_generic_build/zephyr/include/zephyr/spinlock.h:136
	Invalid spinlock 0x9e0b8538
[   58.637608] <err> os: xtensa_excint1_c:  **    (INTLEVEL:0 EXCM: 0 UM:1 RING:0 WOE:1 OWB:2 CALLINC:2)
[   58.637818] <err> os: xtensa_excint1_c:  **    (INTLEVEL:0 EXCM: 0 UM:1 RING:0 WOE:1 OWB:8 CALLINC:2)
[   58.638031] <err> os: xtensa_excint1_c:  **    (INTLEVEL:0 EXCM: 0 UM:1 RING:0 WOE:1 OWB:14 CALLINC:2)
[   58.638241] <err> os: xtensa_excint1_c:  **    (INTLEVEL:0 EXCM: 0 UM:1 RING:0 WOE:1 OWB:4 CALLINC:2)
[   58.638493] <err> os: xtensa_excint1_c:  **    (INTLEVEL:0 EXCM: 0 UM:1 RING:0 WOE:1 OWB:10 CALLINC:2)
[   58.638731] <err> os: xtensa_excint1_c:  **    (INTLEVEL:0 EXCM: 0 UM:1 RING:0 WOE:1 OWB:0 CALLINC:2)
[   58.638908] <err> os: xtensa_excint1_c:  **    (INTLEVEL:0 EXCM: 0 UM:1 RING:0 WOE:1 OWB:6 CALLINC:2)
ASSERTION FAIL [z_spin_lock_valid(l)] @ /srv/home/jenkins/workspace/sof_generic_build/zephyr/include/zephyr/spinlock.h:136
ASSERTION FAIL [z_spin_lock_valid(l)] @ /srv/home/jenkins/workspace/sof_generic_build/zephyr/include/zephyr/spinlock.h:136
ASSERTION FAIL [z_spin_lock_valid(l)] @ /srv/home/jenkins/workspace/sof_generic_build/zephyr/include/zephyr/spinlock.h:136
ASSERTION FAIL [z_spin_lock_valid(l)] @ /srv/home/jenkins/workspace/sof_generic_build/zephyr/include/zephyr/spinlock.h:136
ASSERTION FAIL [z_spin_lock_valid(l)] @ /srv/home/jenkins/workspace/sof_generic_build/zephyr/include/zephyr/spinlock.h:136
ASSERTION FAIL [z_spin_lock_valid(l)] @ /srv/home/jenkins/workspace/sof_generic_build/zephyr/include/zephyr/spinlock.h:136

No other failure in that run.

(ACE MTL https://sof-ci.01.org/sofpr/PR8493/build14994/devicetest is all green and so is https://sof-ci.01.org/sof-pr-viewer/#/build/PR8493/build13133892)

@marc-hb
Copy link
Collaborator Author

marc-hb commented Nov 18, 2023

Same [ 58.637265] <err> ipc: ipc4_module_process_dx: failed to disable core 2 regression in this other, unrelated PR: https://sof-ci.01.org/sofpr/PR8495/build15001/devicetest/index.html?model=ADLP_RVP_NOCODEC_IPC4ZPH&testcase=multiple-pause-resume-5

@RanderWang
Copy link
Collaborator

This is a random issue after we enable multi-core test on CAVS platform while no such issue on ACE platform.

@dbaluta
Copy link
Collaborator

dbaluta commented Nov 20, 2023

@marc-hb this fails because CI is not updated to latest toolchain SDK. We can merge this now and re-add it again once the toolchain is updgraded.

@iuliana-prodan
Copy link
Contributor

@marc-hb this fails because CI is not updated to latest toolchain SDK. We can merge this now and re-add it again once the toolchain is updgraded.

zephyrproject-rtos/zephyr#63751 this is still open

@kv2019i kv2019i merged commit 7737efa into thesofproject:main Nov 20, 2023
43 of 44 checks passed
@marc-hb marc-hb deleted the imx8ulp-not-all branch November 23, 2023 00:14
@marc-hb
Copy link
Collaborator Author

marc-hb commented Nov 23, 2023

This is a random issue after we enable multi-core test on CAVS platform

Thanks, please share links to the corresponding PRs, issues, etc.

Also, please revert, debug, fix and resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuliana-prodan iuliana-prodan iuliana-prodan approved these changes

@RanderWang RanderWang RanderWang approved these changes

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@LaurentiuM1234 LaurentiuM1234 Awaiting requested review from LaurentiuM1234

@fredoh9 fredoh9 Awaiting requested review from fredoh9

@kv2019i kv2019i Awaiting requested review from kv2019i kv2019i is a code owner

@aiChaoSONG aiChaoSONG Awaiting requested review from aiChaoSONG

@softwarecki softwarecki Awaiting requested review from softwarecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marc-hb @RanderWang @dbaluta @iuliana-prodan @kv2019i