Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audio: google_rtc_audio_processing: fixup undeclared identifier #8487

Merged
merged 1 commit into from
Nov 20, 2023
Merged

audio: google_rtc_audio_processing: fixup undeclared identifier #8487

merged 1 commit into from
Nov 20, 2023

Conversation

yongzhi1
Copy link
Contributor

This is fixup for d4b27bf

@yongzhi1 yongzhi1 requested a review from a team as a code owner November 16, 2023 22:55
lyakh
lyakh reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@lyakh lyakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add this file to be compile-tested by our CI?

lgirdwood
lgirdwood approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu is our stub able to build all 3P code now for CI uses ?

@singalsu
Copy link
Collaborator

singalsu commented Nov 17, 2023 •
edited
Loading

@singalsu is our stub able to build all 3P code now for CI uses ?

Yes, I've been able to run all RTC AEC, IGO_NR, RTNR components with stubs in a minimal test pipeline & tplg and hear audio play.

Edit: Though the PRs for two latter are not yet merged. The components won't work as such in git main. One doesn't even build.

@kv2019i kv2019i merged commit 4c25202 into thesofproject:main Nov 20, 2023
43 of 44 checks passed
@yongzhi1 yongzhi1 deleted the srcb branch December 2, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btian1 btian1 btian1 approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@lyakh lyakh lyakh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yongzhi1 @singalsu @lyakh @lgirdwood @btian1 @kv2019i