Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Test: Audio: Remove unused argument from src_test.m #8486

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Tools: Test: Audio: Remove unused argument from src_test.m #8486

merged 1 commit into from
Nov 20, 2023

Conversation

singalsu
Copy link
Collaborator

In function test_run_src() the second argument "t" is not used so it can be safely removed.

@singalsu
Tools: Test: Audio: Remove unused argument from src_test.m
7158a2e 
In function test_run_src() the second argument "t" is not used
so it can be safely removed.

Signed-off-by: Seppo Ingalsuo <[email protected]>
@singalsu singalsu mentioned this pull request Nov 16, 2023
Merged
@singalsu singalsu marked this pull request as ready for review November 16, 2023 16:53
ShriramShastry
ShriramShastry approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@ShriramShastry ShriramShastry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes.

@lgirdwood
Copy link
Member

@wszypelt @lrudyX this is a matlab cleanup, not part of CI test, good to merge ? Thanks !

@lrudyX
Copy link

lrudyX commented Nov 17, 2023

@wszypelt @lrudyX this is a matlab cleanup, not part of CI test, good to merge ? Thanks !

False positive. Good to merge

@lgirdwood
Copy link
Member

@wszypelt @lrudyX this is a matlab cleanup, not part of CI test, good to merge ? Thanks !

False positive. Good to merge

Thanks. Merging.

@lgirdwood lgirdwood merged commit 980b988 into thesofproject:main Nov 20, 2023
42 of 44 checks passed
@singalsu singalsu deleted the src_test_fix_unused_var branch January 4, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShriramShastry ShriramShastry ShriramShastry approved these changes

@btian1 btian1 btian1 approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@singalsu @lgirdwood @lrudyX @btian1 @ShriramShastry