idc: check if secondary core is down before sending IDC #8466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinszkudlinski
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
marcinszkudlinski
force-pushed
the
IDC-check
branch
from
2b24af0 to
82406bc
Compare
ranj063
approved these changes
Nov 9, 2023
plbossart
approved these changes
Nov 9, 2023
7 tasks
kv2019i
approved these changes
Nov 9, 2023
| @@ -119,6 +129,10 @@ int idc_send_msg(struct idc_msg *msg, uint32_t mode) | |||
| work->handler = idc_handler; | |||
| work->sync = mode == IDC_BLOCKING; | |||
|
|
|||
| if (!cpu_is_core_enabled(target_cpu)) { | |||
| tr_err(&zephyr_idc_tr, "Core %u is down, cannot sent IDC message", target_cpu); | |||
|
Mandatory CI check is failing, otherwise this is good to go. |
tmleman
approved these changes
Nov 13, 2023
abonislawski
approved these changes
Nov 14, 2023
lgirdwood
approved these changes
Nov 14, 2023
|
@marcinszkudlinski can you check CI, this is blocking merge today. Thanks ! |
If for any reason a secondary core is down, IDC message has no chance to be processed. This may lead to process hang in case of blocking calls and to undefined actions in case of non blocking. This commit adds a check and error log message in case of target core is down. Signed-off-by: Marcin Szkudlinski <[email protected]>
marcinszkudlinski
force-pushed
the
IDC-check
branch
from
82406bc to
f08ffb3
Compare
|
just rebase to newest main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for any reason a secondary core is down, IDC message has no chance to be processed. This may lead to process hang in case of blocking calls and to undefined actions in case of non blocking.
This commit adds a check and error log message in case of target core is down.