Tools: Topology2: Add widget class IGO NR #8450
Conversation
| @@ -0,0 +1,91 @@ | |||
| # | |||
| # | |||
| # A generic IGO_NR component. All attributes defined herein are namespaced | |||
There was a problem hiding this comment.
I suggest add full name of IGO_NR in a place, let everyone know what exactly IGO_NR is.
There was a problem hiding this comment.
@singalsu , are you adding full name for IGO_NR?
There was a problem hiding this comment.
Yep, I will update this simple PR next. Don't approve yet.
| } | ||
| Object.Base.ops.1 { | ||
| name "ctl" | ||
| info "volsw" |
There was a problem hiding this comment.
add comment for what "volsw" is, for all abbreviation names that not so obvious to know the meanning.
There was a problem hiding this comment.
The legal values are "volsw", "volsw_sx" and "volsw_xr_sx", and the value describes the kcontrol type of the mixer. It somehow describes how the mixer values are interpreted. The relevant functions are implemented in sound/soc/soc-ops.c, but I can not immediately say what is the relevant difference, or find any piece of documentation describing it.
There was a problem hiding this comment.
Thanks @jsarha I'll check if I can understand what they are and add a comment. This has not been clear to me either, I've just copied working topology examples from others.
There was a problem hiding this comment.
Volsw is the single (mono) or double (stereo) mixer control. The _sx version is for use where signed values can be both sides of zero. _xr_sx is some multi-register to single combine control. I'll add some comment but it's not going to be well descriptive. E.g. ALSA documentation is not describing these, only lists the operations names @jsarha mentioned above.
This patch allows to build topologies to use the IGO NR component. Signed-off-by: Seppo Ingalsuo <[email protected]>
This patch adds build of hda-generic development topologies to test IGO NR component with all s16/s24/s32 formats. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
tplg2_igonr_add
branch
from
3826070 to
2101f88
Compare
No description provided.