Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Topology2: Add widget class RTNR #8449

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Tools: Topology2: Add widget class RTNR #8449

merged 2 commits into from
Nov 16, 2023

Conversation

singalsu
Copy link
Collaborator

@singalsu singalsu commented Nov 6, 2023

No description provided.

@singalsu
Tools: Topology2: Add widget class RTNR
d45e036 
This patch allows to build topologies to use the RTNR
component. Two bytes control blobs are converted from
topology1 to IPC4 format.

Signed-off-by: Seppo Ingalsuo <[email protected]>
@singalsu
Tools: Topology2: Add sof-hda-benchmark-rtnr16/24/32-<platform>
2e67f7c 
This patch adds build of hda-generic development topologies to
test RTNR component with all s16/s24/s32 formats.

Signed-off-by: Seppo Ingalsuo <[email protected]>
@singalsu singalsu marked this pull request as ready for review November 8, 2023 08:35
lgirdwood
lgirdwood approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @ranj063 needs to approve.

@lgirdwood
Copy link
Member

@kv2019i any comments ?

@lgirdwood lgirdwood added this to the v2.8 milestone Nov 13, 2023
@kv2019i
Copy link
Collaborator

kv2019i commented Nov 13, 2023

@ranj063 @jsarha ping, will merge later this week if no further comments.

jsarha
jsarha approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@jsarha jsarha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks syntactically correct. Would be helpful, if it would at least once be written somewhere what RTNR stands for. I had to use Google to know what this for 😅.

@kv2019i kv2019i merged commit 2ab6fe5 into thesofproject:main Nov 16, 2023
42 of 44 checks passed
@singalsu
Copy link
Collaborator Author

Looks syntactically correct. Would be helpful, if it would at least once be written somewhere what RTNR stands for. I had to use Google to know what this for 😅.

True, I could have added same pointer as in firmware. This was min. effort to get component to run with supplied stubs library. We have now two NR solutions in SOF, though closed library licensing is needed to use them. Hope the companies can contribute to these files e.g. links to their products web pages for their new customers.

@singalsu singalsu deleted the tplg2_rtnr_add branch January 4, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kv2019i kv2019i kv2019i approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@jsarha jsarha jsarha approved these changes

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8
Development

Successfully merging this pull request may close these issues.
4 participants
@singalsu @lgirdwood @kv2019i @jsarha