Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Src tplg fix #8412

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Src tplg fix #8412

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6703729
Topology2: fix 22khz obs setting
btian1 Oct 30, 2023
5aa7c35
Topology2: fix obs size for src converter from 48k
btian1 Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/topology/topology2/include/components/src_format_s32_convert_from_48k.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
]
out_bit_depth [ 32 ]
out_valid_bit_depth [ 32 ]
obs "$[($out_channels * (($[($out_rate + 999)] / 1000) + 4)) * ($out_bit_depth / 8)]"
# actual buffer size in sof is obs * 2, so here simply set to its period size
obs "$[$out_channels * ($out_bit_depth / 8) * (($out_rate / 1000)) * ($period / 1000)]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btian1 But isn't this the same definition we have in the baseline? So if this doesn't require custom obs logic, we can remove this altogether?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs "$[($out_channels * ($[($out_rate + 999)] / 1000)) * ($out_bit_depth / 8)]"

this adding period into count, however, this may change further, a lot of related changes are happening.
let's wait and see.

}
]

Expand Down