rimage: module: Fix section order in output image

[softwarecki]

Fixed the order in which sections are placed in the output firmware image for platforms using a simple manifest.

Fixes: #8336

[kv2019i]

@saisurya-ch can you verify?

[marc-hb]

@softwarecki can you explain why this didn't affect Intel? Because we don't use a "simple" (?) manifest?

[saisurya-ch]

.ri file is written in the correct order as required.

[kv2019i]

This would be ready to go, but we need a clean run of the mandatory CI checks. @softwarecki can you check?

[softwarecki]

@softwarecki can you explain why this didn't affect Intel? Because we don't use a "simple" (?) manifest?

It appears that Intel platforms use functions from the manifest.c file to generate a firmware image. They work by copying content of sections to allocated memory block, taking into account the starting address of each section. Then this block is written to a output file. The mentioned amd platforms apparently use functions from file_simple.c. That's why I described it as a "simple" manifest. They take sections from a input file and write their content to a output file. This is actually a simpler approach.

[marc-hb]

@kv2019i , @lgirdwood , based on @softwarecki's description of file_simple.c and manifest.c we won't need to backport this to rimage/stable-v2.7, agreed? Or should we do it anyway just to be on the safe side?

[lgirdwood]

@kv2019i , @lgirdwood , based on @softwarecki's description of file_simple.c and manifest.c we won't need to backport this to rimage/stable-v2.7, agreed? Or should we do it anyway just to be on the safe side?

Not impacting v2.7.1, but can be added to v2.7.2 if we need to.

[kv2019i]

@wszypelt @softwarecki The fails look unrelated to this PR, can you take a lot or give go-ahead to merge as this is urgent for non-Intel configurations.

[wszypelt]

@wszypelt @softwarecki The fails look unrelated to this PR, can you take a lot or give go-ahead to merge as this is urgent for non-Intel configurations.

all green in Internal Intel CI System :)