topology1: remove Intel GLK/TGL/ADL/RPL topology definitions #8389
Conversation
kv2019i
requested review from
plbossart,
lyakh,
lgirdwood,
singalsu and
Vamshigopal
kv2019i
force-pushed
the
202310-tplg1-remove-remaining-intel-targets
branch
from
af4daeb to
50c6a3d
Compare
|
@singalsu any thoughts what we should do with testbench. It now fails due to missing definitions: https://github.com/thesofproject/sof/actions/runs/6640839670/job/18042051210?pr=8389 |
I think testbench CI check would need to use topology2 examples. @singalsu any suggestions ? |
|
@singalsu @lgirdwood Or one alternative is we maintain a minimal set of Intel tplg1 m4 files to use in testbench. Then we could do some form of IPC3 debug via testbench. This would still ensure tplg patches will not be sent to wrong branches (e.g. tplg1 Intel stuff should go to stable-v2.2 now). |
To achieve that specific objective, trimming the CMakeLists.txt files is enough, no need to touch .m4 files. Except for people who edit code and submit changes without even compiling them first but I genuinely think these rare people would get what they deserve :-) |
The test topologies build still fails. @kv2019i should remove generate of topologies those depend on dmic.m4. It's probably the shell scripts in tools/test/topology. I've been doing to tools/topology/topology2/include/bench replacement for tplg1 topololgies for test but the work is not yet ready. ETA for ipc4 & tplg2 testbench is end of this Q. |
|
@kv2019i I just sent to you proposal how to fix test topologies build for scripts/host-testbench.sh usage. |
kv2019i
force-pushed
the
202310-tplg1-remove-remaining-intel-targets
branch
from
50c6a3d to
840f4f5
Compare
|
V2 pushed:
|
A simplified copy of previous bxt.m4 is made as local platform/generic.m4 with SSP and other platform definitions for test topologies build. It is included to test-all, test-capture, and test-playback macros definitions. Signed-off-by: Seppo Ingalsuo <[email protected]>
These topologies are no longer supported by mainline firmware code for these platforms. The stable-v2.2 branch continues to support these targets with topology1. Also SOF main branch provides topology2 targets for a subset of these configurations. Signed-off-by: Kai Vehmanen <[email protected]>
These topologies are no longer supported by mainline firmware code for these platforms. The stable-v2.2 branch continues to support these targets with topology1. Also SOF main branch provides topology2 targets for a subset of these configurations.