Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

west.yml: update Zephyr to 460c2167e4f3 #8386

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Oct 25, 2023

Contains 800+ commits merged after 3.5.0 release, including following directly affecting SOF targets:

f4cb487b79f9 modules: sof: Options only when module is available
02deea0e806a ace: alh: Only ACE1.5 has OSEL feature
f0326f72498c tests: dma_loopback: Intel ADSP ACE15 disable PM
adf6d0e3d80e soc: intel_adsp: lpsram enable retention mode
eeb4f2f76d6d soc: intel_adsp: hpsram enable retention mode
16f729214b50 soc: intel_adsp: lpsram init refactor
112611378f85 soc: intel_adsp: hpsram init refactor
cdd4d8470323 xtensa: add custom mem range check functions

@kv2019i
Copy link
Collaborator Author

kv2019i commented Oct 25, 2023

This should fix #8345

Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blanket approval since it enables LNL in CI

@lgirdwood
Copy link
Member

@keqiaozhang @marc-hb fyi - not seeing any results in CI, however status is reported.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Oct 25, 2023

@tmleman There's a FrequencyMismatch / LowQuality fail in Intel QB with test_113_02_simple_internal_loopback on two platforms. Any idea if this could be related to the SRAM retention patches? Seems a bit farfetched, but I can't see other PRs on Zephyr side having on impact here.

https://sof-ci.01.org/sof-pr-viewer/#/build/PR8386/build13001973

@marc-hb
Copy link
Collaborator

marc-hb commented Oct 26, 2023

SOFCI TEST

EDIT: https://sof-ci.01.org/sofpr/PR8386/build14137/devicetest and https://sof-ci.01.org/sofpr/PR8386/build14138/devicetest and were empty due to "new build service growing pains"

@tmleman
Copy link
Contributor

tmleman commented Oct 26, 2023

@tmleman There's a FrequencyMismatch / LowQuality fail in Intel QB with test_113_02_simple_internal_loopback on two platforms. Any idea if this could be related to the SRAM retention patches? Seems a bit farfetched, but I can't see other PRs on Zephyr side having on impact here.

https://sof-ci.01.org/sof-pr-viewer/#/build/PR8386/build13001973

Indeed farfetched when you take into account that there are changes that directly affect the ssp :) it will work if you will revert this zephyrproject-rtos/zephyr#62596

Retention mode can affect performance, but I made manual test and there is regression on MTL in terms of SSP introduced by the PR mentioned above.

There was a question about the correct value of DAI_INTEL_SSP_FIFO_DEPTH that no one answered. Maybe this is the problem?

@kv2019i
Copy link
Collaborator Author

kv2019i commented Oct 26, 2023

Thanks @tmleman , I had missed that patch. @ujfalusi can you take a look?

@kv2019i kv2019i changed the title west.yml: update Zephyr to dc431a739 [DNM] west.yml: update Zephyr to dc431a739 Oct 27, 2023
@kv2019i
Copy link
Collaborator Author

kv2019i commented Oct 27, 2023

More time is needed to find a good fix for the SSP drain problem, so for now, we'll revert the SSP changes zephyrproject-rtos/zephyr#64458 and @ujfalusi will follow-up with a version of the patch that passes QB loopback test. This will unblock the Zephyr update to SOF in the meantime, but we'll need to wait until 64458 is merged.

@kv2019i kv2019i force-pushed the 202310-zephyr-update-oct25 branch from 65f500a to 00773c5 Compare October 29, 2023 08:22
@kv2019i kv2019i changed the title [DNM] west.yml: update Zephyr to dc431a739 west.yml: update Zephyr to 460c2167e4f3 Oct 29, 2023
Contains 600+ commits merged after 3.5.0 release, including following
directly affecting SOF targets:

76cb2a54f51f intel_adsp: Do not include device_runtime header
1fac5ed2a60b soc: xtensa/nxp_adsp: put guard in Kconfig.defconfig
f4cb487b79f9 modules: sof: Options only when module is available
02deea0e806a ace: alh: Only ACE1.5 has OSEL feature
f0326f72498c tests: dma_loopback: Intel ADSP ACE15 disable PM
adf6d0e3d80e soc: intel_adsp: lpsram enable retention mode
eeb4f2f76d6d soc: intel_adsp: hpsram enable retention mode
16f729214b50 soc: intel_adsp: lpsram init refactor
112611378f85 soc: intel_adsp: hpsram init refactor
cdd4d8470323 xtensa: add custom mem range check functions

Signed-off-by: Kai Vehmanen <[email protected]>
@kv2019i
Copy link
Collaborator Author

kv2019i commented Oct 29, 2023

v2 update:

  • one SSP driver PR reverted, this should fix the QB test for now (base don test runs down with just revert alone)

@kv2019i
Copy link
Collaborator Author

kv2019i commented Oct 30, 2023

All clean now, proceeding with merge.

@kv2019i kv2019i merged commit 1c729f4 into thesofproject:main Oct 30, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants