audio: aria: Add set_large_config op #8338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
btian1
reviewed
Oct 18, 2023
kv2019i
requested changes
Oct 18, 2023
This patch is needed to make the module work with linux and avoid firmware crash. This patch sets the attenuation parameters with the bytes control since the setup parameters can't be passed in init() as in Windows OS. Signed-off-by: Ranjani Sridharan <[email protected]> Signed-off-by: Seppo Ingalsuo <[email protected]>
Signed-off-by: Ranjani Sridharan <[email protected]> Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
aria_patches_to_run_benchmark
branch
from
43672c6 to
eabd5fb
Compare
|
@abonislawski Does this add look OK to you? |
kv2019i
approved these changes
Oct 19, 2023
| @@ -30,6 +30,7 @@ CONFIG_COMP_VOLUME_WINDOWS_FADE=y | |||
| CONFIG_COMP_DRC=y | |||
There was a problem hiding this comment.
@singalsu checkpatch does not like commits without description. as other checks are green, I think I'll let this pass through, but note for future.
btian1
approved these changes
Oct 20, 2023
|
Ignoring "sof-ci/jenkins/pr-tools-build", rest of CI checks are good, proceeding with merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is needed to make the module work with linux and avoid firmware crash. This patch sets the attenuation parameters with the bytes control since the setup parameters can't be passed in init() as in Windows OS.