topology2: google-rtc-aec: expose component core_id for override #8308
Conversation
|
@yongzhi1 I guess we need other PRs for FW and SW from @marcinszkudlinski and @ranj063 before we can merge ? |
Yes, that's right. The DP AEC support has dependency on #8403; thesofproject/linux#4664 and other fix. |
yongzhi1
changed the title
|
Update: Fix the comment to avoid confusion. |
| @@ -95,7 +95,10 @@ Define { | |||
| BT_PB_DAI_PIPELINE_SRC "copier.host.9.1" | |||
| BT_PB_PIPELINE_STREAM_NAME "dai-copier.SSP.10.1" | |||
| GOOGLE_RTC_AEC_SUPPORT 0 | |||
| # assign core for AEC LL pipelines | |||
| GOOGLE_AEC_CORE_ID 0 | |||
There was a problem hiding this comment.
Do we need to run AEC as LL?
There was a problem hiding this comment.
@marcinszkudlinski I think this is for the rest of the pipeline on which AEC is.
There was a problem hiding this comment.
yes, for example, as a test we can run echo ref related pipelines on core 2 (LL), and put RTC_AEC module (DP) alone on core 1:
There was a problem hiding this comment.
ok, so comment is a little confusing. We should update it to say AEC is using DP and rest of pipeline is LL and both are on different cores.
There was a problem hiding this comment.
Ack, will update commit message as well as the PR description, thanks,
RTC_AEC module is using DP and rest of pipeline is LL and both can run on different cores. For the purpose to assign DP module individually on secondary core, now add a new macro GOOGLE_AEC_DP_CORE_ID. Signed-off-by: Yong Zhi <[email protected]>
|
Update: |
RTC AEC module is using DP and rest of echo ref pipeline is LL, and both can run on secondary cores.
In order to assign RTC_AEC DP alone on secondary core, add new macro GOOGLE_AEC_DP_CORE_ID.