-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "module_adapter: avoid module init crash in case of ipc data invalid" #8303
Conversation
@@ -79,6 +79,9 @@ int module_adapter_init_data(struct comp_dev *dev, | |||
return ret; | |||
} | |||
dst->init_data = dst->data; | |||
} else if (size == 0) { | |||
/* valid case for mixer */ | |||
return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is the case, do we still need keep line 85 - 87?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest a revert and then do a follow-up to make a new fix to avoiding module init crashes (if a generic module level solution is possible, not sure it is).
@@ -79,6 +79,9 @@ int module_adapter_init_data(struct comp_dev *dev, | |||
return ret; | |||
} | |||
dst->init_data = dst->data; | |||
} else if (size == 0) { | |||
/* valid case for mixer */ | |||
return 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…nvalid" This reverts 'commit e847c8b ("module_adapter: avoid module init crash in case of ipc data invalid")'. No data is not an invalid case for mixer, for example. Fixes: thesofproject#8265 Signed-off-by: Iuliana Prodan <[email protected]>
0264032
to
22d9e9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @btian1 can you do a follow-up?
Revert "module_adapter: avoid module init crash in case of ipc data invalid"
This reverts 'commit e847c8b ("module_adapter: avoid module
init crash in case of ipc data invalid")'.
No data is not an invalid case for mixer, for example.
Fixes: #8265
Signed-off-by: Iuliana Prodan [email protected]