Audio: TDFB: Update component for IPC4 #8279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
force-pushed
the
tdfb_add_ipc4_support
branch
from
ee8d384 to
2fdf121
Compare
singalsu
requested review from
RanderWang,
marcinszkudlinski,
pblaszko,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lyakh
reviewed
Oct 4, 2023
src/audio/tdfb/tdfb.c
Outdated
| } | ||
| #endif /* CONFIG_IPC_MAJOR_4 */ | ||
|
|
||
| #if CONFIG_IPC_MAJOR_3 |
src/audio/tdfb/tdfb.c
Outdated
| @@ -633,17 +712,82 @@ static int tdfb_cmd_set_value(struct processing_module *mod, struct sof_ipc_ctrl | |||
| comp_err(mod->dev, "tdfb_cmd_set_value() error: invalid cdata->cmd"); | |||
| return -EINVAL; | |||
| } | |||
| #endif /* CONFIG_IPC_MAJOR_3 */ | |||
|
|
|||
| #if CONFIG_IPC_MAJOR_4 | |||
src/audio/tdfb/tdfb.c
Outdated
| return -EINVAL; | ||
| #endif | ||
|
|
||
| #if CONFIG_IPC_MAJOR_3 |
src/audio/tdfb/tdfb.c
Outdated
|
|
||
| #if CONFIG_IPC_MAJOR_3 |
src/audio/tdfb/tdfb.c
Outdated
| } | ||
| #endif /* CONFIG_IPC_MAJOR_4 */ | ||
|
|
||
| #if CONFIG_IPC_MAJOR_3 |
This patch adds struct sof_ipc4_notify_module_data that matches the Linux kernel handler for notifications from firmware to ALSA user space. The SOF_IPC4_NOTIFY_MODULE_EVENTID_ALSA_MAGIC_VAL event_id is used to identify the notifications for ALSA controls like switch and enum. Signed-off-by: Peter Ujfalusi <[email protected]> Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
tdfb_add_ipc4_support
branch
from
2fdf121 to
c6ce720
Compare
This patch updates the Time domain fixed beamformer (TDFB) module prepare() to set in tdfb_params() IPC4 sink and source parameters from initialization IPC. The notifications send to user space for sound direction of arrival is updated to work with IPC4 ALSA notifications. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
force-pushed
the
tdfb_add_ipc4_support
branch
from
c6ce720 to
6c7f67b
Compare
lgirdwood
approved these changes
Oct 5, 2023
btian1
reviewed
Oct 9, 2023
| @@ -173,6 +173,7 @@ struct ipc4_message_reply { | |||
|
|
|||
| #define SOF_IPC4_SWITCH_CONTROL_PARAM_ID 200 | |||
| #define SOF_IPC4_ENUM_CONTROL_PARAM_ID 201 | |||
| #define SOF_IPC4_NOTIFY_MODULE_EVENTID_ALSA_MAGIC_VAL ((uint32_t)(0xA15A << 16)) | |||
There was a problem hiding this comment.
why not directly with 0xA15A0000
kv2019i
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch adds the needed IPC4 header
Second patch updates the TDFB component