ipc4: handler: Add fallthrough comment to prevent compilation error #8228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the fallthrough comment to prevent the error seen with shared library build: "handler.c:312:20: error: this statement may fall through [-Werror=implicit-fallthrough=]" Signed-off-by: Ranjani Sridharan <[email protected]>
ranj063
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
btian1
approved these changes
Sep 20, 2023
lyakh
reviewed
Sep 20, 2023
| @@ -311,6 +311,7 @@ int ipc4_pipeline_prepare(struct ipc_comp_dev *ppl_icd, uint32_t cmd) | |||
| case SOF_IPC4_PIPELINE_STATE_EOS: | |||
| if (status != COMP_STATE_ACTIVE) | |||
| return IPC4_INVALID_REQUEST; | |||
| /* fallthrough */ | |||
There was a problem hiding this comment.
@lyakh compiler_fallthrough doesn't seem to help with the host build with ipc4. What am I missing?
There was a problem hiding this comment.
Ok, looking at the definition:
sof/xtos/include/sof/compiler_attributes.h
Lines 45 to 54 in 992dd67
__attribute__((fallthrough)) definition is used, but that attribute isn't known to your compiler and it's ignoring an unknown attribute. Can you try -Wignored-attributes (note, that when building with sparse enabled, the -Wno-attributes option is used, which suppresses such warnings)
There was a problem hiding this comment.
Zephyr has a universal "fallthrough" that we could copy/re-use #8383 (comment)
cc: @singalsu
|
pulled into #8232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the fallthrough comment to prevent the error seen with shared library build:
"handler.c:312:20: error: this statement may fall through [-Werror=implicit-fallthrough=]"