-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Topology2: Change in capture gain curve_duration to 50 ms #8208
Tools: Topology2: Change in capture gain curve_duration to 50 ms #8208
Conversation
This change increases the ramp duration from 20 ms to 50 ms. It lowers the peak load of peak volume component due to longer same gain value blocks. The internal update rate for gain becomes 250 us instead of 125 us. The longer fade-in ramp also conceals better possible analog capture start transients. This changes for 4ch capture for gain.11.1 in sof-hda-generic-4ch.tplg from CPU_PEAK(MAX) = 21.95 PEAK(MAX)/AVG(AVG) = 7.51 to CPU_PEAK(MAX) = 9.07 PEAK(MAX)/AVG(AVG) = 3.12 Signed-off-by: Seppo Ingalsuo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to 40/50/60ms have same result for peak ramp results, better to have a check for the result.
@marcinszkudlinski @mwasko fyi - good improvement on MCPS |
@singalsu @lgirdwood seems CI still failed, either change CI pass reference or revert this patch. |
@lgirdwood tests uses different curve duration, and according to my knowledge it should not be static as curve length is being defined in InitInstance ipc or LargeConfigSet message of Gain module |
@btian1 If you mean issue #8238 the bug is in CI, not in topology or gain component. Alsabat or using alsabat from sof-test should have a way to ignore from start the ramp time. |
@mszleszy Yes, the gain component follows the curve_duration and curve_type request from init() IPC. But currently the curve duration and curve type from successive volume commands is ignored. Also we can't have different curve per channel. |
@singalsu as far as i know setting up different configs per channel was supported up to cavs2.5 It's not required any longer but the structure stayed the same for back compatibility. |
Yep, we should not attempt to tame the peak MCPS with ways those cause regressions. |
This change increases the ramp duration from 20 ms to 50 ms. It lowers the peak load of peak volume component due to longer same gain value blocks. The internal update rate for gain becomes 250 us instead of 125 us. The longer fade-in ramp also conceals better possible analog capture start transients.
This changes for 4ch capture for gain.11.1 in sof-hda-generic-4ch.tplg from
CPU_PEAK(MAX) = 21.95
PEAK(MAX)/AVG(AVG) = 7.51
to
CPU_PEAK(MAX) = 9.07
PEAK(MAX)/AVG(AVG) = 3.12