Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology1: add sof-rpl-rt711-l0-rt1316-l12.tplg support #8198

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

bardliao
Copy link
Collaborator

Adding sof-rpl-rt711-l0-rt1316-l12.tplg. The topology is the same as sof-rpl-rt711-l0-rt1316-l12-rt714-l3, but without local mic (rt714).

Adding sof-rpl-rt711-l0-rt1316-l12.tplg. The topology is the same
as sof-rpl-rt711-l0-rt1316-l12-rt714-l3, but without local mic (rt714).

Signed-off-by: Bard Liao <[email protected]>
@mengdonglin mengdonglin requested a review from kv2019i September 14, 2023 11:59
@mengdonglin
Copy link
Collaborator

@KV2019 This is for customer RPL device. Should such topology updates go to v2.2.x or v2.7?

@lgirdwood lgirdwood merged commit 3eada7c into thesofproject:main Sep 14, 2023
41 checks passed
@kv2019i
Copy link
Collaborator

kv2019i commented Sep 14, 2023

@mengdonglin so this needs to be backported to stable-v2.2 and then include it to a sof-bin release that will include the latest v2.2-tplg package

@lgirdwood we probably should remove all these Intel tplg1 files from main, to make it clear tplg1 updates (for Intel platforms) need to be submitted to stable-v2.2

@plbossart
Copy link
Member

@lgirdwood we probably should remove all these Intel tplg1 files from main, to make it clear tplg1 updates (for Intel platforms) need to be submitted to stable-v2.2

Or move topologies out of the sof repos....

@marc-hb
Copy link
Collaborator

marc-hb commented Sep 14, 2023

Or move topologies out of the sof repos....

And then move them back in a couple years later :-)

Quoting that issue:

https://en.wikipedia.org/wiki/Conway%27s_law aside (does not apply here), the ability to make arbitrary combinations is probably the only good reason to have multiple, independent repos. For instance we want the latest SOF-TEST branch to be able to test most SOF branches out of the box. We don't want to branch SOF-TEST every time that we branch SOF, that would be much more work. Obviously, you also don't want SOF-TEST code to change while bisecting SOF. So: a different repo for SOF-TEST. It's different for lower level CMocka unit tests which are in the same repo.

So is there a frequent need to test arbitrary combinations of sof.git version X with sof-TPLG.git version Y [*]? I haven't heard of any so far. If not then a separate repo is a lot of overhead for no value.

[*] I really mean source repos in git. Binary releases are different; many projects release multiple packages from a single repo all the time, this is routine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants