Remove sparse cache annotations from buffer/audio_stream step2 #8167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinszkudlinski
force-pushed
the
remove_sparse_step2
branch
3 times, most recently
from
0bf420e to
eb2fd05
Compare
2 tasks
marcinszkudlinski
force-pushed
the
remove_sparse_step2
branch
from
eb2fd05 to
cb3a8c5
Compare
marcinszkudlinski
requested review from
bardliao,
pblaszko,
a team,
ranj063,
jxstelter,
abonislawski,
tlissows,
singalsu,
fkwasowi,
iganakov,
RanderWang,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
kv2019i
approved these changes
Sep 11, 2023
kv2019i
changed the title
3 tasks
struct audio_stream __sparse_cache => struct audio_stream struct comp_buffer __sparse_cache => struct comp_buffer struct sof_source __sparse_cache => struct sof_source struct sof_sink __sparse_cache => struct sof_sinkurce this commit is 100% generated by editor find/replace + one cosmetic change (intent correction to make checkpatch happy) Signed-off-by: Marcin Szkudlinski <[email protected]>
Prev commit removing __sparse was a pure editor action, this commit is removing some other __sparse annotations and mappings that must have been done manually This commit contains "safe" changes only Signed-off-by: Marcin Szkudlinski <[email protected]>
after removal of __Sparse some of lines may be formatted differently. This commit contains cosmetic changes only Signed-off-by: Marcin Szkudlinski <[email protected]>
marcinszkudlinski
force-pushed
the
remove_sparse_step2
branch
from
cb3a8c5 to
4b37871
Compare
abonislawski
approved these changes
Sep 11, 2023
lgirdwood
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is removal of sparse annotations:
struct audio_stream __sparse_cache => struct audio_stream
struct comp_buffer __sparse_cache => struct comp_buffer
struct sof_source __sparse_cache => struct sof_source
struct sof_sink __sparse_cache => struct sof_sink
One of the commits touches many files/lines, but is rather safe and easy to review because all changes were made by editors string find&replace - as above
To keep sparse checker happy there's no other choice - need remove all annotations in one step
UPDATE: for context #8006