loging: add logging through probes #8163
Conversation
dabekjakub
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
dabekjakub
force-pushed
the
jdabek-probe-logging-upstream
branch
from
ee9fa5e to
bcee460
Compare
There was a problem hiding this comment.
Thanks, now I understand better. I think we should unify the IPC handling and at least put the mtrace/probe enable/dsiable calls in some common place so we can reuse the IPC code.
I think we can leave the policy call whether the two can be enabled to build time, but the code should at least allow to build with both.
dabekjakub
force-pushed
the
jdabek-probe-logging-upstream
branch
2 times, most recently
from
301cdea to
84c2126
Compare
|
@kv2019i updated build to error if both are enabled - it would anyway from redefinition but there is an error for now. Added function to check if backend is configured and result in error when not. Should be good to go now. |
dabekjakub
force-pushed
the
jdabek-probe-logging-upstream
branch
from
84c2126 to
913f00f
Compare
There was a problem hiding this comment.
Thanks @dabekjakub , looks good now! One small thing still in patch, can you take a look?
Logging with probes was not implemented. This implements ipc that enables logging with probe configuration. Signed-off-by: Jakub Dabek <[email protected]>
dabekjakub
force-pushed
the
jdabek-probe-logging-upstream
branch
from
913f00f to
c4a9dfc
Compare
|
One fail in pause-resume in https://sof-ci.01.org/sofpr/PR8163/build12942/devicetest , but does not seem to be related to this PR (and no errors in either dmesg or mtrace, aplay just returns non-zero on one iteration, rest are fine). Proceeding with merge. |
|
https://github.com/thesofproject/sof/actions/runs/6187233612/job/16796644911 was failing. Fixed in #8222 |
Logging with probes was not implemented. This implements ipc that enables logging with probe configuration.