Skip to content

Commit

Permalink
intel_adsp_ace15_mtpm.conf: replace blanket _STUBS with focused RTC MOCK
Browse files Browse the repository at this point in the history
CONFIG_COMP_STUBS=y was enabled in #8722 / commit 8e34109 ("AEC:
Enable Google AEC with Mock compliation").

CONFIG_COMP_STUBS indirectly enables
CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK which was the desired
effect. However it also automatically and silently "mocks" all other 3rd
party modules which is not desirable. So, replace it with the more
focused `CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK`. `src/audio/Kconfig`
says "CONFIG_STUBS: This should only be used in testing environments
like fuzzers or CI."

It's not clear why official sof-bin releases should include
`google_rtc_audio_processing_mock.c` but that's another topic for
another day.

build-mtl/zephyr.strip is identical before versus after this commit.

Signed-off-by: Marc Herbert <[email protected]>
  • Loading branch information
marc-hb committed Aug 24, 2024
1 parent 7b021f6 commit 805364f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion app/boards/intel_adsp_ace15_mtpm.conf
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@ CONFIG_PROBE=y
CONFIG_PROBE_DMA_MAX=2
CONFIG_LOG_TIMESTAMP_64BIT=y

# Not sure why this is part of official sof-bin releases?
# See #8722 and #9386
CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING=y
CONFIG_COMP_STUBS=y
CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK=y

CONFIG_KCPS_DYNAMIC_CLOCK_CONTROL=y

0 comments on commit 805364f

Please sign in to comment.