sof-dump-status.py: don't crash on unknown Intel audio PCI devices #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set pci_info['hw_name'] to "PCI device unknown by SOF" and keep going.
Before this commit, any test that invokes sof-dump-status.py for any
reason crashes like this when the PCI ID is unknown:
```
Traceback (most recent call last):
File "sof-test/tools/sof-dump-status.py", line 497, in <module>
sysinfo.loadPCI()
File "sof-test/tools/sof-dump-status.py", line 139, in loadPCI
pci_info['hw_name'] = self._pci_ids["0x" + tmp_line[4] + tmp_line[3]]
KeyError: '0xe328'
```
The lack of a known PCI ID does not have to be fatal: there are plenty
of use cases where the PCI ID is not needed. This commit makes it
possible to run all these test cases even when the PCI ID is unknown.
This could help with thesofproject#288 too.
Signed-off-by: Marc Herbert <[email protected]>
|
No new pylint warning introduced https://github.com/thesofproject/sof-test/actions/runs/9392159406/job/25865808201?pr=1204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set pci_info['hw_name'] to "PCI device unknown by SOF" and keep going.
Before this commit, any test that invokes sof-dump-status.py for any reason crashes like this when the PCI ID is unknown:
The lack of a known PCI ID does not have to be fatal: there are plenty of use cases where the PCI ID is not needed. This commit makes it possible to run all these test cases even when the PCI ID is unknown.
This could help with #288 too.