Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up topology section in tools/README.md #1197

Merged
merged 3 commits into from
May 21, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented May 20, 2024

3 commits, you must review commits separately because the first commit extract a new tools/README.md from the existing, top-level README.md

No content change (yet)

Signed-off-by: Marc Herbert <[email protected]>
We have multiple scripts parsing topologies and it's impossible to guess
the differences. Try to clarify the current status in tools/README.md

Signed-off-by: Marc Herbert <[email protected]>
Too much confusion all over the place to perform a mass search/replace
so add a warning only at the top of the "help" text.

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb marc-hb marked this pull request as ready for review May 20, 2024 21:55
@marc-hb marc-hb requested a review from a team as a code owner May 20, 2024 21:55
@marc-hb
Copy link
Collaborator Author

marc-hb commented May 20, 2024

pylint failures in https://github.com/thesofproject/sof-test/actions/runs/9165401424/job/25198761862?pr=1197 are very old; not going to fix warnings on a deprecated tool and certainly not in this small, focused PR.

@marc-hb
Copy link
Collaborator Author

marc-hb commented May 21, 2024

Known alsabat capture issue on LNL, everything else green.

Copy link
Collaborator

@fredoh9 fredoh9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we have good README for tools

@marc-hb
Copy link
Collaborator Author

marc-hb commented May 21, 2024

Thanks Fred. In the extremely unlikely case anyone else has comments, feel free to keep commenting post-merge.

@marc-hb marc-hb merged commit 0ce2375 into thesofproject:main May 21, 2024
5 of 7 checks passed
@marc-hb marc-hb deleted the topo-README branch May 21, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants