-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verify-kernel-boot-log.sh: fix missing boot logs on failure #1191
Conversation
Provide a new, boot_logs.txt file no matter what happens. Note that file now includes user-space logs, not just kernel logs. Also: fix bug where script times out and does not run when the SOF firmware is not loaded: no need to define NO_POLL_FW_LOADING anymore. The trick is to stop calling `start_test()`. verify-kernel-boot-log.sh is not an audio test! Fixes sof-test issues thesofproject#1036 and thesofproject#1112, find more details there. Signed-off-by: Marc Herbert <[email protected]>
Wow, ALL hardware tests are 100% green! The new |
{ | ||
local exit_code=$1 | ||
|
||
journalctl --boot > "$LOG_ROOT"/boot_log.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally I don't pay attention to user space log at boot. What can we expect more clues from user space log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What can we expect more clues from user space log?
- Sound daemons errors (pulseaudio, pipewire,...)
- Display / auto-login issues: Ubuntu 22: Wayland aborts without a connected monitor. No hotplug either + Xorg weird crash #964, Ubuntu22: GDM does not report missing GPU -> use reliable lightdm instead? #998
- Anything else that could give clues.
If you look at some examples, you'll see the added volume is low compared to SOF debug logs. One example on a fresh boot:
root@jf-lnlm-rvp-nocodec-3:~# journalctl -k | wc -l
1857
root@jf-lnlm-rvp-nocodec-3:~# journalctl -b | wc -l
2313
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more after looking at diff -u <(journalctl -k) <(journalctl -b) | less
- Network initialization
- NTP init
- sensors stuff (thermal)
- other systemd logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beauty of trap! Looks good.
Thanks a lot!
Provide a new, boot_logs.txt file no matter what happens. Note that file now includes user-space logs, not just kernel logs.
Also: fix bug where script times out and does not run when the SOF
firmware is not loaded: no need to define NO_POLL_FW_LOADING anymore.
The trick is to stop calling
start_test()
. verify-kernel-boot-log.sh is not an audio test!Fixes sof-test issues #1036 and #1112, find more details there.