Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNLM_SDW_AIOC.sh: overrides the headset detected_mode #1190

Merged
merged 1 commit into from
May 10, 2024

Conversation

fredoh9
Copy link
Collaborator

@fredoh9 fredoh9 commented May 8, 2024

LNL RVP keep toggling between headphone and headset. Overrides to headset only for the test.

Related kernel PR: thesofproject/linux#4969

@fredoh9 fredoh9 requested a review from a team as a code owner May 8, 2024 18:57
@fredoh9 fredoh9 requested review from plbossart and marc-hb May 8, 2024 18:57
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not going to fail without thesofproject/linux#4969 ?

We want to keep a reasonable amount of backwards compatibility.

alsa_settings/LNLM_SDW_AIOC.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: add a comment with the URL. Without context it's impossible to guess why this is done.

@fredoh9 fredoh9 force-pushed the fix/lnl_sdw_aioc_headset_mode branch from 0ef13de to 35751d7 Compare May 8, 2024 21:42
@fredoh9 fredoh9 requested a review from marc-hb May 8, 2024 21:42
marc-hb
marc-hb previously approved these changes May 8, 2024
bardliao
bardliao previously approved these changes May 9, 2024
@marc-hb marc-hb marked this pull request as draft May 9, 2024 16:43
LNL RVP keep toggling between headphone and headset. Overrides to headset
only for the test.

Signed-off-by: Fred Oh <[email protected]>
@fredoh9 fredoh9 dismissed stale reviews from bardliao and marc-hb via ac6a188 May 9, 2024 16:47
@fredoh9 fredoh9 force-pushed the fix/lnl_sdw_aioc_headset_mode branch from 35751d7 to ac6a188 Compare May 9, 2024 16:47
@fredoh9 fredoh9 marked this pull request as ready for review May 9, 2024 16:52
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @fredoh9

@fredoh9 fredoh9 merged commit 90e0929 into thesofproject:main May 10, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants