sof_perf_analyzer: fix exception when kernel message not provided #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
requested changes
Oct 11, 2023
If kernel message file is not provided, the component_name
dict will be empty, in calculating the maximum length of
component names, we calls the max function with an empty
sequence, which raises below error:
"ValueError: max() arg is an empty sequence"
This patch checks if component_name dict is empty, and on
empty, provides a default value.
Signed-off-by: Chao Song <[email protected]>
marc-hb
approved these changes
Oct 12, 2023
btian1
approved these changes
Oct 13, 2023
|
SOFCI TEST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If kernel message file is not provided, the component_name dict will be empty, in calculating the maximum length of component names, we calls the max function with an empty sequence, which raises below error:
"ValueError: max() arg is an empty sequence"
This patch checks if component_name dict is empty, and on empty, provides a default value.