Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-sof-logger.sh: more robust fix to runtime-PM race #1111

Conversation

kv2019i
Copy link
Contributor

@kv2019i kv2019i commented Oct 9, 2023

It turns out on some test platforms, the launch of logger processes can take significant amount of time, so the solution to create some DSP activity just before launching the logger processes, is not reliable enough.

Implement alternative solution where the DSP activity is triggered after loggers are started.

Fix tested with a modified mtrace-reader.py that injects arbitrary delays at startup.

@kv2019i kv2019i requested a review from a team as a code owner October 9, 2023 15:58
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly OK.

test-case/check-sof-logger.sh Outdated Show resolved Hide resolved
test-case/check-sof-logger.sh Outdated Show resolved Hide resolved
test-case/check-sof-logger.sh Outdated Show resolved Hide resolved
@marc-hb
Copy link
Collaborator

marc-hb commented Oct 9, 2023

https://sof-ci.01.org/softestpr/PR1111/build786/devicetest/index.html is all green so maybe you finally nailed it?

@kv2019i kv2019i force-pushed the 202310-fix-ci499-check-soflogger-attempt-ii branch from 51fb192 to 71e5e02 Compare October 19, 2023 19:16
It turns out on some test platforms, the launch of logger
processes can take significant amount of time, so the solution
to create some DSP activity just before launching the logger
processes, is not reliable enough.

Implement alternative solution where the DSP activity is
triggered after loggers are started.

Fix tested with a modified mtrace-reader.py that injects
arbitrary delays at startup.

Signed-off-by: Kai Vehmanen <[email protected]>
@kv2019i
Copy link
Contributor Author

kv2019i commented Oct 19, 2023

@marc-hb @fredoh9 Please re-review. I did a custom test run 33338 that covers all daily test configurations and all tests passed with this PR now, so I think this finally covers all cases.

Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-hb marc-hb merged commit e4dd610 into thesofproject:main Oct 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants